From 319a7b0cb93fa7e45201b1c6f38f4cbef53d8300 Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Tue, 10 Jul 2012 17:27:39 +0200
Subject: [PATCH 1/4] report field: use getValue() as default for
 getSelectValue()

---
 expert/field.py  | 2 +-
 expert/report.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/expert/field.py b/expert/field.py
index 502f34a..2295771 100644
--- a/expert/field.py
+++ b/expert/field.py
@@ -36,7 +36,7 @@ from loops import util
 class Field(BaseField):
 
     def getSelectValue(self, row):
-        return self.getRawValue(row)
+        return self.getValue(row)
 
 
 class TextField(Field):
diff --git a/expert/report.py b/expert/report.py
index 2255ce9..c213a33 100644
--- a/expert/report.py
+++ b/expert/report.py
@@ -1,5 +1,5 @@
 #
-#  Copyright (c) 2011 Helmut Merz helmutm@cy55.de
+#  Copyright (c) 2012 Helmut Merz helmutm@cy55.de
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by

From 62077c5dfbf598de1f3d170bcb3a9977a3209418 Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Fri, 13 Jul 2012 10:43:11 +0200
Subject: [PATCH 2/4] use first type token as default type token, thus showing
 the correct fields in the create form

---
 browser/form.py        |  2 ++
 browser/form_macros.pt | 14 +++++---------
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/browser/form.py b/browser/form.py
index aa59167..9e0ac7f 100644
--- a/browser/form.py
+++ b/browser/form.py
@@ -396,6 +396,8 @@ class CreateConceptForm(CreateObjectForm):
                             parentType.getChildren([subtypePred]))
             types = [dict(token=ConceptTypeInfo(t).token, title=t.title)
                         for t in tconcepts]
+        if self.defaultTypeToken is None and types:
+            self.defaultTypeToken = types[0]['token']
         if include or include is None:
             return util.KeywordVocabulary(types + self.listTypes(include, ('hidden',)))
         return util.KeywordVocabulary(types)
diff --git a/browser/form_macros.pt b/browser/form_macros.pt
index 47f56b1..0ab2fe2 100644
--- a/browser/form_macros.pt
+++ b/browser/form_macros.pt
@@ -78,7 +78,10 @@
       id="dialog_form" class="dialog"
       dojoType="dijit.form.Form"
       tal:define="qualifier request/qualifier|view/qualifier|string:resource;
-                  innerForm request/inner_form|view/inner_form|string:inner_form.html;
+                  innerForm 
+                    request/inner_form|view/inner_form|string:inner_form.html;
+                  typesVocabulary python:
+                            view.getTypesVocabulary((qualifier,));
                   typeToken view/typeToken;
                   fixedType view/fixedType;
                   langInfo view/languageInfo;
@@ -104,8 +107,7 @@
                                     '${view/virtualTargetUrl}/$innerForm')">
                 <option value=".loops/concepts/note"
                         i18n:translate=""
-                        tal:repeat="type python:
-                            view.getTypesVocabulary((qualifier,))"
+                        tal:repeat="type typesVocabulary"
                         tal:content="type/title"
                         tal:attributes="value type/token;
                                         selected python:type.token == typeToken">
@@ -115,12 +117,6 @@
               <input type="hidden" name="form.type"
                      tal:condition="fixedType"
                      tal:attributes="value typeToken" />
-              <script type="text/javascript"
-                      tal:condition="not:fixedType"
-                      tal:content="string:replaceFieldsNode(
-                                    'form.fields', 'form.type',
-                                    '${view/virtualTargetUrl}/$innerForm')">
-              </script>
         </th></tr></tbody>
 
         <tbody><tr><td colspan="5">

From 14b670166a5438cc6a83413702e947b364e6c38c Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Fri, 13 Jul 2012 18:19:46 +0200
Subject: [PATCH 3/4] provide new 'getViewForObject()' method for getting views
 in listings; use new view attribute 'listingTitle' in listings

---
 browser/common.py           | 44 ++++++++++++++++++++++++++++---------
 expert/browser/search.pt    |  2 +-
 organize/tracking/report.py |  9 +++++---
 3 files changed, 41 insertions(+), 14 deletions(-)

diff --git a/browser/common.py b/browser/common.py
index 997a179..d3d96f5 100644
--- a/browser/common.py
+++ b/browser/common.py
@@ -389,6 +389,40 @@ class BaseView(GenericView, I18NView):
     def uniqueId(self):
         return util.getUidForObject(self.context)
 
+    @Lazy
+    def breadcrumbsTitle(self):
+        return self.title
+
+    @Lazy
+    def listingTitle(self):
+        return self.title
+
+    def getViewForObject(self, obj):
+        if obj is not None:
+            obj = baseObject(obj)
+            basicView = component.getMultiAdapter((obj, self.request))
+            if hasattr(basicView, 'view'):
+                return basicView.view
+
+    def viewIterator(self, objs):
+        request = self.request
+        for obj in objs:
+            view = self.getViewForObject(obj)
+            if view is None:
+                view = BaseView(obj, request)
+            yield view
+
+    def xx_viewIterator(self,obj):
+            view = component.queryMultiAdapter(
+                            (o, request), name='index.html')
+            #if view is None:
+            #    view = component.queryMultiAdapter((o, request), IBrowserView)
+            if view is None:
+                view = BaseView(o, request)
+            if hasattr(view, 'view'):   # use view setting for type
+                view = view.view
+            yield view
+
     # type stuff
 
     @Lazy
@@ -431,16 +465,6 @@ class BaseView(GenericView, I18NView):
             return absoluteURL(provider, self.request)
         return None
 
-    def viewIterator(self, objs):
-        request = self.request
-        for o in objs:
-            view = component.queryMultiAdapter((o, request), name='index.html')
-            #if view is None:
-            #    view = component.queryMultiAdapter((o, request), IBrowserView)
-            if view is None:
-                view = BaseView(o, request)
-            yield view
-
     def renderText(self, text, contentType):
         text = util.toUnicode(text)
         typeKey = util.renderingFactories.get(contentType, None)
diff --git a/expert/browser/search.pt b/expert/browser/search.pt
index 4bcfc4d..ac45dd4 100644
--- a/expert/browser/search.pt
+++ b/expert/browser/search.pt
@@ -122,7 +122,7 @@
                       <img tal:define="icon row/icon"
                            tal:condition="icon"
                            tal:attributes="src icon/src" />
-                      <div tal:content="row/title" /></a>
+                      <div tal:content="row/listingTitle" /></a>
                   </td>
                   <td i18n:translate="" class="center"
                       tal:content="row/longTypeTitle|row/typeTitle">Type</td>
diff --git a/organize/tracking/report.py b/organize/tracking/report.py
index 5ebff0f..db04490 100644
--- a/organize/tracking/report.py
+++ b/organize/tracking/report.py
@@ -18,8 +18,6 @@
 
 """
 Adapter and view class(es) for statistics reporting.
-
-$Id$
 """
 
 from datetime import date, datetime
@@ -268,9 +266,14 @@ class TrackDetails(BaseView):
         obj = self.object
         node = self.view.nodeView
         url = node is not None and node.getUrlForTarget(obj) or ''
+        view = self.view.getViewForObject(obj)
+        if view is None:
+            title = obj.title
+        else:
+            title = view.listingTitle
         versionable = IVersionable(self.object, None)
         version = versionable is not None and versionable.versionId or ''
-        return dict(object=obj, title=obj.title,
+        return dict(object=obj, title=title,
                     type=self.longTypeTitle, url=url, version=version,
                     canAccess=canAccessObject(obj))
 

From 944bb0e308d93631d95bc14c94ad5ac0416df30f Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sat, 14 Jul 2012 09:25:51 +0200
Subject: [PATCH 4/4] avoid double submit in Internet Explorer

---
 browser/form_macros.pt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/browser/form_macros.pt b/browser/form_macros.pt
index 0ab2fe2..39f6669 100644
--- a/browser/form_macros.pt
+++ b/browser/form_macros.pt
@@ -309,7 +309,7 @@
               <input value="Save" type="submit"
                      i18n:attributes="value"
                      tal:attributes="onClick python: view.closeAction(True) or
-                            'submit()'">
+                            'return true'">
               <input type="button" value="Cancel" onClick="dlg.hide();"
                      i18n:attributes="value"
                      tal:condition="view/isInnerHtml"