comments: restrict to logged-in users; improve validateion

compound/book/loops_book_de.dmp

@@ -21,6 +21,7 @@ concept(u'issubtype', u'is Subtype', u'predicate', options=u'hide_children',
 # document types
 concept(u'keyquestions', u'Leitfragen', u'documenttype')
 concept(u'textelement', u'Textabschnitt', u'documenttype')
+concept(u'textelement2', u'Textabschnitt separat', u'documenttype')
 concept(u'quote', u'Zitat', u'documenttype')
 concept(u'story', u'Geschichte', u'documenttype')
 concept(u'usecase', u'Fallbeispiel', u'documenttype')

locales/de/LC_MESSAGES/loops.po

@@ -3,7 +3,7 @@ msgstr ""
 
 "Project-Id-Version: $Id$\n"
 "POT-Creation-Date: 2007-05-22 12:00 CET\n"
-"PO-Revision-Date: 2012-08-20 12:00 CET\n"
+"PO-Revision-Date: 2012-09-17 12:00 CET\n"
 "Last-Translator: Helmut Merz <helmutm@cy55.de>\n"
 "Language-Team: loops developers <helmutm@cy55.de>\n"
 "MIME-Version: 1.0\n"
@@ -755,6 +755,9 @@ msgstr "Kommentare"
 msgid "Add Comment"
 msgstr "Kommentar hinzufügen"
 
+msgid "Subject"
+msgstr "Thema"
+
 msgid "Selection using: $targets"
 msgstr "Auswahl über: $targets"
 

organize/comment/browser.py

@@ -1,5 +1,5 @@
 #
-#  Copyright (c) 2008 Helmut Merz helmutm@cy55.de
+#  Copyright (c) 2012 Helmut Merz helmutm@cy55.de
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -18,8 +18,6 @@
 
 """
 Definition of view classes and other browser related stuff for comments.
-
-$Id$
 """
 
 from zope import interface, component
@@ -52,6 +50,8 @@ class CommentsView(NodeView):
 
     @Lazy
     def allowed(self):
+        if self.isAnonymous:
+            return False
         return (self.virtualTargetObject is not None and
                     self.globalOptions('organize.allowComments'))
 
@@ -120,8 +120,8 @@ class CreateComment(EditObject):
     def update(self):
         form = self.request.form
         subject = form.get('subject')
-        text = form.get('text')
-        if not subject or not text or self.personId is None or self.object is None:
+        text = form.get('text') or u''
+        if not subject or self.personId is None or self.object is None:
             return True
         #contentType = form.get('contentType') or 'text/restructured'
         rm = self.view.loopsRoot.getRecordManager()

organize/comment/comment_macros.pt

@@ -58,7 +58,7 @@
       </div>
       <div class="buttons">
         <input value="Save" type="submit"
-               onClick="return closeDialog(true)"
+               onClick="if (not this.validate()) return False; return closeDialog(true)"
                i18n:attributes="value">
         <input type="button" value="Cancel"
                onClick="return closeDialog(false)"