cco/loops
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

performance improvement: only create new relation if necessary, simplified

Browse source
This commit is contained in:
Helmut Merz 2011-11-21 12:30:00 +01:00
parent 1d5b525a59
commit c6638e7b5e
1 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
common.py
View file

@ -355,12 +355,6 @@ class ParentRelationSet(RelationSet):
def add(self, related, order=0, relevance=1.0): def add(self, related, order=0, relevance=1.0):
related = baseObject(related) related = baseObject(related)
existing = list(self.context.getParentRelations([self.predicate], related,
noSecurityCheck=self.noSecurityCheck))
if len(existing) == 1:
rel = existing[0]
if rel.order == order and rel.relevance == relevance:
return
self.context.deassignParent(related, [self.predicate], # avoid duplicates self.context.deassignParent(related, [self.predicate], # avoid duplicates
noSecurityCheck=self.noSecurityCheck) noSecurityCheck=self.noSecurityCheck)
self.context.assignParent(related, self.predicate, order, relevance) self.context.assignParent(related, self.predicate, order, relevance)
@ -396,12 +390,6 @@ class ChildRelationSet(RelationSet):
def add(self, related, order=0, relevance=1.0): def add(self, related, order=0, relevance=1.0):
related = baseObject(related) related = baseObject(related)
existing = list(self.context.getChildRelations([self.predicate], related,
noSecurityCheck=self.noSecurityCheck))
if len(existing) == 1:
rel = existing[0]
if rel.order == order and rel.relevance == relevance:
return
self.context.deassignChild(related, [self.predicate]) # avoid duplicates self.context.deassignChild(related, [self.predicate]) # avoid duplicates
self.context.assignChild(related, self.predicate, order, relevance) self.context.assignChild(related, self.predicate, order, relevance)
@ -499,6 +487,7 @@ class ParentRelation(object):
if current != value: if current != value:
s.remove(current) s.remove(current)
if value is not None: if value is not None:
if value not in s:
s.add(value) # how to supply additional parameters? s.add(value) # how to supply additional parameters?