From babb2228682d55728a08993906b86d7acdaa74d0 Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Thu, 12 Nov 2015 15:45:29 +0100
Subject: [PATCH] starting to move authentication to cco.member package; allow
 special characters in logout's nextUrl

---
 browser/configure.zcml | 4 ++--
 browser/node.py        | 7 +++++++
 browser/node_macros.pt | 3 +--
 3 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/browser/configure.zcml b/browser/configure.zcml
index 7d1713d..e4dec31 100644
--- a/browser/configure.zcml
+++ b/browser/configure.zcml
@@ -539,13 +539,13 @@
 
   <!-- query views -->
 
-  <zope:adapter
+  <!--<zope:adapter
       name="login.html"
       for="loops.interfaces.IConcept
            zope.publisher.interfaces.browser.IBrowserRequest"
       provides="zope.interface.Interface"
       factory="loops.browser.auth.LoginConcept"
-      permission="zope.View" />
+      permission="zope.View" />-->
 
   <zope:adapter
       name="list_children.html"
diff --git a/browser/node.py b/browser/node.py
index 51939e0..00cf611 100755
--- a/browser/node.py
+++ b/browser/node.py
@@ -20,6 +20,7 @@
 View class for Node objects.
 """
 
+import urllib
 from urlparse import urlparse, urlunparse
 from zope import component, interface, schema
 from zope.cachedescriptors.property import Lazy
@@ -418,6 +419,12 @@ class NodeView(BaseView):
     def active(self, item):
         return item.context == self.context or item.context in self.parents
 
+    @Lazy
+    def logoutUrl(self):
+        nextUrl = urllib.urlencode(dict(nextUrl=self.menu.url))
+        return 'logout.html?' + nextUrl
+
+
     # virtual target support
 
     @Lazy
diff --git a/browser/node_macros.pt b/browser/node_macros.pt
index a3c6bf3..3432f53 100644
--- a/browser/node_macros.pt
+++ b/browser/node_macros.pt
@@ -327,8 +327,7 @@
 
 
 <metal:actions define-macro="personal">
-    <div><a href="logout.html?nextURL=login.html"
-            tal:attributes="href string:logout.html?nextURL=${view/menu/url}"
+    <div><a tal:attributes="href view/logoutUrl"
             i18n:translate="">Log out</a></div>
     <tal:actions repeat="action python:view.getAllowedActions('personal')">
       <metal:action use-macro="action/macro" />