From a67c19659a7a3d29f5ced9062c9c21afe73f9366 Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sun, 24 Mar 2013 17:15:06 +0100
Subject: [PATCH] more flexible layout for states info and stateful actions;
 improved/more flexible translateion facilities

---
 browser/common.py            |  5 +++++
 browser/form_macros.pt       | 17 +++++++++++------
 organize/stateful/browser.py | 10 ++++++++--
 3 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/browser/common.py b/browser/common.py
index c7e0528..69b54b6 100644
--- a/browser/common.py
+++ b/browser/common.py
@@ -154,6 +154,11 @@ class BaseView(GenericView, I18NView):
     def checkPermissions(self):
         return canAccessObject(self.context)
 
+    def translate(self, text, msgFactory=_):
+        if msgFactory is None:
+            return text
+        return msgFactory(text)
+
     @Lazy
     def contextInfo(self):
         return dict(view=self, context=getName(self.context))
diff --git a/browser/form_macros.pt b/browser/form_macros.pt
index 63543d3..f56b708 100644
--- a/browser/form_macros.pt
+++ b/browser/form_macros.pt
@@ -274,18 +274,22 @@
 </metal:versioning>
 
 
-<metal:states define-macro="states"
+<metal:states define-macro="states">
+    <tr><td colspan="5" i18n:translate="" class="headline">States</td></tr>
+    <metal:states define-macro="states_info"
                   tal:define="states view/states"
                   tal:condition="states">
-      <tr><td colspan="5" i18n:translate="" class="headline">States</td></tr>
       <tr tal:repeat="st states">
         <tal:state define="stObj st/getStateObject;
                            stDef st/statesDefinition;
                            stTrans st/getAvailableTransitionsForUser">
-          <td colspan="2" i18n:translate=""
-              tal:content="stDef">loops.simple_publishing</td>
-          <td i18n:translate=""
-              tal:content="stObj/title">draft</td>
+          <td colspan="2">
+            <b i18n:translate=""
+               tal:content="python:view.translate(stDef, st.msgFactory)">
+              loops.simple_publishing</b>:&nbsp;</td>
+          <td>
+            <span i18n:translate=""
+                  tal:content="stObj/title">draft</span>&nbsp;</td>
           <td>
             <select name="state.loops.simple_publishing"
                     tal:condition="stTrans"
@@ -300,6 +304,7 @@
           <td />
         </tal:state>
       </tr>
+    </metal:states>
 </metal:states>
 
 
diff --git a/organize/stateful/browser.py b/organize/stateful/browser.py
index ae57c87..8dc1069 100644
--- a/organize/stateful/browser.py
+++ b/organize/stateful/browser.py
@@ -1,5 +1,5 @@
 #
-#  Copyright (c) 2012 Helmut Merz helmutm@cy55.de
+#  Copyright (c) 2013 Helmut Merz helmutm@cy55.de
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -47,6 +47,7 @@ class StateAction(Action):
 
     url = None
     definition = None
+    msgFactory = _
 
     @Lazy
     def stateful(self):
@@ -56,6 +57,7 @@ class StateAction(Action):
     @Lazy
     def description(self):
         lang = self.view.languageInfo.language
+        _ = self.msgFactory
         definition = translate(_(self.definition), target_language=lang)
         title = translate(_(self.stateObject.title), target_language=lang)
         return _(u'State information for $definition: $title',
@@ -71,12 +73,16 @@ class StateAction(Action):
         return 'cybertools.icons/' + icon
 
 
-for std in statefulActions:
+def registerStatefulAction(std, msgFactory=_):
     actions.register('state.' + std, 'object', StateAction,
             definition = std,
             cssClass='icon-action',
+            msgFactory=msgFactory,
     )
 
+for std in statefulActions:
+    registerStatefulAction(std)
+
 
 #class StateQuery(ConceptView):
 class StateQuery(BaseView):