From 9f9e3509337cba372eea596747aa2de679ea06fe Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Fri, 30 Dec 2011 12:47:23 +0100
Subject: [PATCH 1/8] work in progress: extend reporting features - report
 'meeting minutes'

---
 organize/work/README.txt     | 52 +++++++++++++++++++++++++++--
 organize/work/configure.zcml | 11 +++++++
 organize/work/report.py      | 64 +++++++++++++++++++++++++++---------
 3 files changed, 109 insertions(+), 18 deletions(-)

diff --git a/organize/work/README.txt b/organize/work/README.txt
index 2dea1a0..1702ea9 100644
--- a/organize/work/README.txt
+++ b/organize/work/README.txt
@@ -2,8 +2,6 @@
 loops - Linked Objects for Organization and Processing Services
 ===============================================================
 
-  ($Id$)
-
 Let's do some basic setup
 
   >>> from zope.app.testing.setup import placefulSetUp, placefulTearDown
@@ -194,6 +192,9 @@ In addition we need a predicate that connects one or more tasks with a report.
   >>> hasReport = addAndConfigureObject(concepts, Concept, 'hasreport',
   ...                   title=u'has Report', conceptType=concepts.getPredicateType())
 
+Work statement report
+---------------------
+
 Now we can create a report and register it as the report for the task
 used above.
 
@@ -235,6 +236,53 @@ in a results view.
   {'effort': 900}
 
 
+Meeting Minutes
+===============
+
+We can use an event with assigned tasks as the basis for planning a meeting
+and recording information about the tasks.
+
+Let's start with creating an a event and assigning it a task.
+
+  >>> from loops.organize.interfaces import ITask
+  >>> tEvent = addAndConfigureObject(concepts, Concept, 'event',
+  ...                   title=u'Event', conceptType=concepts.getTypeConcept(),
+  ...                   typeInterface=ITask)
+
+  >>> ev01 = addAndConfigureObject(concepts, Concept, 'ev01',
+  ...                   title=u'loops Meeting', conceptType=tEvent)
+  >>> ev01.assignChild(task01)
+
+Now we create the meeting minutes report. We assign the event type as a
+child in order to provide the information for which types of objects the
+report is available.
+
+  >>> from loops.organize.work.report import MeetingMinutes
+  >>> component.provideAdapter(MeetingMinutes, provides=IReportInstance,
+  ...                          name='meeting_minutes')
+
+  >>> meetingMinutes = addAndConfigureObject(concepts, Concept, 'meeting_minutes',
+  ...                   title=u'Meeting Minutes', conceptType=tReport,
+  ...                   reportType='meeting_minutes')
+  >>> meetingMinutes.assignChild(tEvent, hasReport)
+
+We can now access the report using a results view.
+
+  >>> from loops.util import getUidForObject
+  >>> input = dict(tasks=getUidForObject(ev01))
+  >>> resultsView = ResultsView(home, TestRequest(form=input))
+  >>> resultsView.virtualTargetObject = meetingMinutes
+
+  >>> results = resultsView.results()
+  >>> len(list(results))
+  1
+  >>> for row in results:
+  ...     for col in resultsView.displayedColumns:
+  ...         print col.getDisplayValue(row),
+  ...     print
+  loops Development
+
+
 Fin de partie
 =============
 
diff --git a/organize/work/configure.zcml b/organize/work/configure.zcml
index ccd434f..e6040c4 100644
--- a/organize/work/configure.zcml
+++ b/organize/work/configure.zcml
@@ -86,6 +86,17 @@
              set_schema="loops.expert.report.IReportInstance" />
   </zope:class>
 
+  <zope:adapter factory="loops.organize.work.report.MeetingMinutes"
+           name="meeting_minutes"
+           provides="loops.expert.report.IReportInstance"
+           trusted="True" />
+  <zope:class class="loops.organize.work.report.MeetingMinutes">
+    <require permission="zope.View"
+             interface="loops.expert.report.IReportInstance" />
+    <require permission="zope.ManageContent"
+             set_schema="loops.expert.report.IReportInstance" />
+  </zope:class>
+
   <!-- setup -->
 
   <zope:adapter factory="loops.organize.work.setup.SetupManager"
diff --git a/organize/work/report.py b/organize/work/report.py
index 7dbefdf..56d2054 100644
--- a/organize/work/report.py
+++ b/organize/work/report.py
@@ -113,7 +113,7 @@ title = Field('title', u'Title',
                 executionSteps=['output'])
 description = Field('description', u'Description',
                 description=u'The long description of the work.',
-                executionSteps=['x_output'])
+                executionSteps=['output'])
 duration = DurationField('duration', u'Duration',
                 description=u'The duration of the work.',
                 executionSteps=['output'])
@@ -125,6 +125,8 @@ state = Field('state', u'State',
                 executionSteps=['query', 'output'])
 
 
+# basic definitions and work report instance
+
 class WorkRow(BaseRow):
 
     def getRawValue(self, attr):
@@ -161,11 +163,13 @@ class WorkReportInstance(ReportInstance):
     rowFactory = WorkRow
 
     fields = Jeep((dayFrom, dayTo, tasks,
-                   day, timeStart, timeEnd, task, party, title, description,
+                   day, timeStart, timeEnd, task, party, title, #description,
                    duration, effort, state))
 
     defaultOutputFields = fields
     defaultSortCriteria = (day, timeStart,)
+    states = ('done', 'done_x', 'finished')
+    taskTypeNames = ('task', 'event', 'project')
 
     @property
     def queryCriteria(self):
@@ -183,22 +187,20 @@ class WorkReportInstance(ReportInstance):
 
     def selectObjects(self, parts):
         result = []
-        tasks = [util.getObjectForUid(t) for t in parts.pop('tasks').comparisonValue]
-        for t in list(tasks):
-            tasks.extend(self.getAllSubtasks(t))
-        for t in tasks:
+        for t in self.getTasks(parts):
             result.extend(self.selectWorkItems(t, parts))
         # remove parts already used for selection from parts list:
         parts.pop('userName', None)
         return result
 
-    def selectWorkItems(self, task, parts):
-        states = ['done', 'done_x', 'finished']
-        kw = dict(task=util.getUidForObject(task), state=states)
-        if 'userName' in parts:
-            kw['userName'] = parts['userName'].comparisonValue
-        wi = self.workItems
-        return wi.query(**kw)
+    def getTasks(self, parts):
+        taskIds = parts.pop('tasks').comparisonValue
+        if not isinstance(taskIds, (list, tuple)):
+            taskIds = [taskIds]
+        tasks = [util.getObjectForUid(t) for t in taskIds]
+        for t in list(tasks):
+            tasks.extend(self.getAllSubtasks(t))
+        return tasks
 
     def getAllSubtasks(self, concept):
         result = []
@@ -208,12 +210,42 @@ class WorkReportInstance(ReportInstance):
             result.extend(self.getAllSubtasks(c))
         return result
 
+    def selectWorkItems(self, task, parts):
+        # TODO: take states from parts
+        kw = dict(task=util.getUidForObject(task), state=self.states)
+        if 'userName' in parts:
+            kw['userName'] = parts['userName'].comparisonValue
+        wi = self.workItems
+        return wi.query(**kw)
+
     @Lazy
     def taskTypes(self):
-        return (self.conceptManager['task'],
-                self.conceptManager['event'],
-                self.conceptManager['project'])
+        return [c for c in [self.conceptManager.get(name)
+                                for name in self.taskTypeNames]
+                  if c is not None]
 
     @Lazy
     def workItems(self):
         return IWorkItems(self.recordManager['work'])
+
+
+# meeting minutes
+
+class TaskRow(BaseRow):
+
+    pass
+
+
+class MeetingMinutes(WorkReportInstance):
+
+    type = "meeting_minutes"
+    label = u'Meeting Minutes'
+
+    rowFactory = TaskRow
+
+    fields = Jeep((tasks, title, description))
+    defaultOutputFields = fields
+
+    def selectObjects(self, parts):
+        return self.getTasks(parts)[1:]
+

From 59bd3cfa2be7b3209cf3ffa5573044e1a1dab4bd Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sat, 31 Dec 2011 11:01:55 +0100
Subject: [PATCH 2/8] bug fix: split only once on ':' for meta tag analysis on
 DC Description

---
 browser/skin/controller.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/browser/skin/controller.py b/browser/skin/controller.py
index a551b4c..1b4be58 100644
--- a/browser/skin/controller.py
+++ b/browser/skin/controller.py
@@ -38,10 +38,11 @@ class Controller(BaseController):
         target = self.view.virtualTarget
         if target is not None:
             desc = target.dcDescription
+            print '***', desc
             if desc:
                 for line in desc.splitlines():
                     if ':' in line:
-                        name, value = line.split(':')
+                        name, value = line.split(':', 1)
                         if name in metaTagNames:
                             macros.register('meta', name, metaName=name,
                                             metaContent=value)

From 8f1d31966fc05eea6ddbb7fe60dedd10ec8b2f86 Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sat, 31 Dec 2011 11:04:33 +0100
Subject: [PATCH 3/8] bug fix: split only once on ':' for meta tag analysis on
 DC Description

---
 browser/skin/controller.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/browser/skin/controller.py b/browser/skin/controller.py
index 1b4be58..30ae2b4 100644
--- a/browser/skin/controller.py
+++ b/browser/skin/controller.py
@@ -38,7 +38,6 @@ class Controller(BaseController):
         target = self.view.virtualTarget
         if target is not None:
             desc = target.dcDescription
-            print '***', desc
             if desc:
                 for line in desc.splitlines():
                     if ':' in line:

From ec4116d88ca3c66cdf1d7b09f739ab74c0824947 Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sun, 1 Jan 2012 12:16:53 +0100
Subject: [PATCH 4/8] use correct URL for type-based sub-form

---
 browser/form_macros.pt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/browser/form_macros.pt b/browser/form_macros.pt
index 5e32cb8..667d643 100644
--- a/browser/form_macros.pt
+++ b/browser/form_macros.pt
@@ -97,7 +97,7 @@
                       tal:attributes="onChange
                             string:return replaceFieldsNode(
                                     'form.fields', 'form.type',
-                                    '${view/url}/$innerForm')">
+                                    '${view/virtualTargetUrl}/$innerForm')">
                 <option value=".loops/concepts/note"
                         i18n:translate=""
                         tal:repeat="type python:
@@ -114,7 +114,7 @@
               <script type="text/javascript"
                       tal:content="string:replaceFieldsNode(
                                     'form.fields', 'form.type',
-                                    '${view/url}/$innerForm')">
+                                    '${view/virtualTargetUrl}/$innerForm')">
               </script>
         </th></tr></tbody>
 

From 84072904e55a33b213e3bd53ac1ce42d61a14a6d Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sun, 1 Jan 2012 12:17:47 +0100
Subject: [PATCH 5/8] do not use standard description field as default for DC
 description

---
 browser/common.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/browser/common.py b/browser/common.py
index 9ab6845..ae5bac9 100644
--- a/browser/common.py
+++ b/browser/common.py
@@ -349,7 +349,7 @@ class BaseView(GenericView, I18NView):
 
     @Lazy
     def dcDescription(self):
-        return self.dublincore.description or self.description
+        return self.dublincore.description or u'' #self.description
 
     @Lazy
     def headTitle(self):

From b469942114f3545cc10ccb5a9fd30bd82314a99a Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sun, 1 Jan 2012 12:18:19 +0100
Subject: [PATCH 6/8] remove obsolete encoding specification

---
 browser/skin/controller.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/browser/skin/controller.py b/browser/skin/controller.py
index 30ae2b4..29418cf 100644
--- a/browser/skin/controller.py
+++ b/browser/skin/controller.py
@@ -1,4 +1,3 @@
-#-*- coding: UTF-8 -*-
 #
 #  Copyright (c) 2011 Helmut Merz helmutm@cy55.de
 #

From 9896c546c36375f85f6b6a9e5856adaf24698acf Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Sun, 1 Jan 2012 13:53:20 +0100
Subject: [PATCH 7/8] use calculated current year for copyright info

---
 browser/skin/lobo/body.pt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/browser/skin/lobo/body.pt b/browser/skin/lobo/body.pt
index cca73aa..b3960aa 100644
--- a/browser/skin/lobo/body.pt
+++ b/browser/skin/lobo/body.pt
@@ -66,7 +66,8 @@
     <div id="footer" class="footer clear"
          metal:define-macro="footer">
       <metal:footer define-slot="footer">
-        &copy; Copyright 2011, cyberconcepts IT-Consulting Dr. Helmut Merz
+        &copy; Copyright <span tal:replace="view/currentYear" />,
+        cyberconcepts IT-Consulting Dr. Helmut Merz
         (<a href="#"
           tal:attributes="href string:${view/topMenu/url}/impressum">Impressum</a>)
         <br />

From 7ca0892551e525b2aefc752614d62fc1a8105d31 Mon Sep 17 00:00:00 2001
From: Helmut Merz <helmutm@cy55.de>
Date: Mon, 2 Jan 2012 09:26:42 +0100
Subject: [PATCH 8/8] reporting, work in progress: sub-report field

---
 expert/browser/results.pt | 31 ++++++++++++++++++++++++++++---
 expert/field.py           | 28 +++++++++++++++++++++++++++-
 organize/work/README.txt  |  3 ++-
 organize/work/report.py   | 39 ++++++++++++++++++++++++++++++++-------
 4 files changed, 89 insertions(+), 12 deletions(-)

diff --git a/expert/browser/results.pt b/expert/browser/results.pt
index 7cdd6ee..0b9344f 100644
--- a/expert/browser/results.pt
+++ b/expert/browser/results.pt
@@ -18,18 +18,18 @@
   <table class="report"
          tal:define="results view/results">
     <tr>
-        <th tal:repeat="col view/displayedColumns"
+        <th tal:repeat="col results/displayedColumns"
             tal:content="col/title"
             i18n:translate="" />
     </tr>
     <tr tal:repeat="row results">
-        <tal:column repeat="col view/displayedColumns">
+        <tal:column repeat="col results/displayedColumns">
             <metal:column use-macro="python:view.getColumnRenderer(col.renderer)" />
         </tal:column>
     </tr>
     <tr tal:define="row nocall:results/totals"
         tal:condition="nocall:row">
-        <tal:column repeat="col view/displayedColumns">
+        <tal:column repeat="col results/displayedColumns">
             <metal:column use-macro="python:view.getColumnRenderer(col.renderer)" />
         </tal:column>
     </tr>
@@ -56,4 +56,29 @@
 </metal:target>
 
 
+<div metal:define-macro="subreport">
+  <td>
+    <table class="subreport"
+           tal:define="results python:col.getValue(row)">
+      <tr>
+        <th tal:repeat="col results/displayedColumns"
+            tal:content="col/title"
+            i18n:translate="" />
+      </tr>
+      <tr tal:repeat="row results">
+        <tal:column repeat="col results/displayedColumns">
+            <metal:column use-macro="python:view.getColumnRenderer(col.renderer)" />
+        </tal:column>
+      </tr>
+      <tr tal:define="row nocall:results/totals"
+        tal:condition="nocall:row">
+        <tal:column repeat="col results/displayedColumns">
+            <metal:column use-macro="python:view.getColumnRenderer(col.renderer)" />
+        </tal:column>
+      </tr>
+    </table>
+  </td>
+</div>
+
+
 </html>
diff --git a/expert/field.py b/expert/field.py
index d386298..43497c1 100644
--- a/expert/field.py
+++ b/expert/field.py
@@ -1,5 +1,5 @@
 #
-#  Copyright (c) 2011 Helmut Merz helmutm@cy55.de
+#  Copyright (c) 2012 Helmut Merz helmutm@cy55.de
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -21,7 +21,9 @@ Field definitions for reports.
 """
 
 from cybertools.composer.report.field import Field
+from cybertools.composer.report.result import ResultSet
 from loops.common import baseObject
+from loops.expert.report import ReportInstance
 from loops import util
 
 
@@ -40,6 +42,8 @@ class UrlField(Field):
 
     def getDisplayValue(self, row):
         nv = row.parent.context.view.nodeView
+        if row.context is None:     # probably a totals row
+            return dict(title=u'', url=u'')
         return dict(title=self.getValue(row),
                     url=nv.getUrlForTarget(baseObject(row.context)))
 
@@ -61,3 +65,25 @@ class TargetField(Field):
         view = row.parent.context.view
         return dict(title=value.title, url=view.getUrlForTarget(value))
 
+
+# sub-report stuff
+
+class SubReport(ReportInstance):
+
+    pass
+
+
+class SubReportField(Field):
+
+    renderer = 'subreport'
+    reportFactory = SubReport
+
+    def getReportInstance(self, row):
+        baseReport = row.parent.context
+        instance = self.reportFactory(baseReport.context)
+        instance.view = baseReport.view
+        return instance
+
+    def getValue(self, row):
+        ri = self.getReportInstance(row)
+        return ResultSet(ri, ri.getResults())
diff --git a/organize/work/README.txt b/organize/work/README.txt
index 1702ea9..5965094 100644
--- a/organize/work/README.txt
+++ b/organize/work/README.txt
@@ -280,7 +280,8 @@ We can now access the report using a results view.
   ...     for col in resultsView.displayedColumns:
   ...         print col.getDisplayValue(row),
   ...     print
-  loops Development
+  {'url': 'http://127.0.0.1/loops/views/home/.36', 'title': u'loops Development'}
+  <cybertools.composer.report.result.ResultSet object ...>
 
 
 Fin de partie
diff --git a/organize/work/report.py b/organize/work/report.py
index 56d2054..c658b48 100644
--- a/organize/work/report.py
+++ b/organize/work/report.py
@@ -1,5 +1,5 @@
 #
-#  Copyright (c) 2011 Helmut Merz helmutm@cy55.de
+#  Copyright (c) 2012 Helmut Merz helmutm@cy55.de
 #
 #  This program is free software; you can redistribute it and/or modify
 #  it under the terms of the GNU General Public License as published by
@@ -33,7 +33,7 @@ from cybertools.util.date import timeStamp2Date
 from cybertools.util.format import formatDate
 from cybertools.util.jeep import Jeep
 from loops.common import adapted, baseObject
-from loops.expert.field import TargetField
+from loops.expert.field import TargetField, TextField, UrlField, SubReportField
 from loops.expert.report import ReportInstance
 from loops import util
 
@@ -84,9 +84,15 @@ class DurationField(Field):
         return u'%02i:%02i' % divmod(value * 60, 60)
 
 
+# common fields
+
 tasks = Field('tasks', u'Tasks',
-                description=u'The tasks from which work items should be selected.',
+                description=u'The tasks from which sub-tasks and '
+                        u'work items should be selected.',
                 executionSteps=['query'])
+
+# work report fields
+
 dayFrom = Field('dayFrom', u'Start Day',
                 description=u'The first day from which to select work.',
                 executionSteps=['query'])
@@ -108,10 +114,10 @@ task = TargetField('taskId', u'Task',
 party = TargetField('userName', u'Party',
                 description=u'The party (usually a person) who did the work.',
                 executionSteps=['query', 'sort', 'output'])
-title = Field('title', u'Title',
+workTitle = Field('title', u'Title',
                 description=u'The short description of the work.',
                 executionSteps=['output'])
-description = Field('description', u'Description',
+workDescription = Field('description', u'Description',
                 description=u'The long description of the work.',
                 executionSteps=['output'])
 duration = DurationField('duration', u'Duration',
@@ -124,6 +130,18 @@ state = Field('state', u'State',
                 description=u'The state of the work.',
                 executionSteps=['query', 'output'])
 
+# task/event report fields
+
+taskTitle = UrlField('title', u'Title',
+                description=u'The short description of the task.',
+                executionSteps=['output'])
+taskDescription = TextField('description', u'Description',
+                description=u'The long description of the task.',
+                executionSteps=['output'])
+workItems = SubReportField('workItems', u'Work Items',
+                description=u'A list of work items belonging to the task.',
+                executionSteps=['output'])
+
 
 # basic definitions and work report instance
 
@@ -163,7 +181,7 @@ class WorkReportInstance(ReportInstance):
     rowFactory = WorkRow
 
     fields = Jeep((dayFrom, dayTo, tasks,
-                   day, timeStart, timeEnd, task, party, title, #description,
+                   day, timeStart, timeEnd, task, party, workTitle, #description,
                    duration, effort, state))
 
     defaultOutputFields = fields
@@ -238,13 +256,20 @@ class TaskRow(BaseRow):
 
 class MeetingMinutes(WorkReportInstance):
 
+    # TODO:
+    # header (event) fields: title, description, from/to,
+    #               location, participants (or put in description?)
+    # result set field for work items
+    # work item fields: title, description, party, deadline, state
+
     type = "meeting_minutes"
     label = u'Meeting Minutes'
 
     rowFactory = TaskRow
 
-    fields = Jeep((tasks, title, description))
+    fields = Jeep((tasks, taskTitle, taskDescription, workItems))
     defaultOutputFields = fields
+    states = ('planned', 'accepted', 'done', 'done_x', 'finished')
 
     def selectObjects(self, parts):
         return self.getTasks(parts)[1:]