cco/go-scopes
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix logging for unit tests

Browse source
This commit is contained in:
Helmut Merz 2023-07-08 08:20:47 +02:00
parent e072e493a1
commit 235ba65c64
4 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/action/action.go
View file

@ -40,6 +40,7 @@ func Select(ctx lib.Context, msg lib.Message) []lib.Action {
} }
} }
} }
// if len(acts) == 0 { logging.Warn().... }
return acts return acts
} }

2
lib/core/core.go
View file

@ -7,6 +7,8 @@ import (
"git.sr.ht/~cco/go-scopes/logging" "git.sr.ht/~cco/go-scopes/logging"
) )
func NoOp(_ lib.Context) {}
func Start(ctx lib.Context) { func Start(ctx lib.Context) {
logging.Debug(ctx).Msg("core.Start") logging.Debug(ctx).Msg("core.Start")
lib.RunCtx(ctx, Listen) lib.RunCtx(ctx, Listen)

5
logging/logging.go
View file

@ -28,7 +28,7 @@ var Levels = map[string]zerolog.Level{
type Logger = zerolog.Logger type Logger = zerolog.Logger
var defaultLogger = log.Logger var defaultLogger = log.Logger.Level(InfoLevel)
var globalLogger *Logger = &log.Logger var globalLogger *Logger = &log.Logger
type Cfg struct { type Cfg struct {
@ -38,7 +38,8 @@ type Cfg struct {
} }
func SetDefault() { func SetDefault() {
globalLogger = &defaultLogger logger := defaultLogger
globalLogger = &logger
} }
func Setup(ctx lib.Context, cfg *Cfg, home string) { func Setup(ctx lib.Context, cfg *Cfg, home string) {

3
tests/unit_test.go
View file

@ -8,6 +8,7 @@ import (
"git.sr.ht/~cco/go-scopes/lib" "git.sr.ht/~cco/go-scopes/lib"
"git.sr.ht/~cco/go-scopes/lib/action" "git.sr.ht/~cco/go-scopes/lib/action"
"git.sr.ht/~cco/go-scopes/lib/context" "git.sr.ht/~cco/go-scopes/lib/context"
"git.sr.ht/~cco/go-scopes/lib/core"
"git.sr.ht/~cco/go-scopes/lib/message" "git.sr.ht/~cco/go-scopes/lib/message"
"git.sr.ht/~cco/go-scopes/testing" "git.sr.ht/~cco/go-scopes/testing"
) )
@ -70,7 +71,7 @@ func ActionTest(t *testing.T) {
return true return true
} }
} }
cfg := config.Base("testing", nil). cfg := config.Base("testing", core.NoOp).
AddAction("start", action.Base(hdlrGen("started"))). AddAction("start", action.Base(hdlrGen("started"))).
AddAction("scopes|doit|task", action.Base(hdlrGen("done"))) AddAction("scopes|doit|task", action.Base(hdlrGen("done")))
ctx := context.AppContext(cfg) ctx := context.AppContext(cfg)